Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Devcontainer from docker hub #1421

Closed
stefjoosten opened this issue Jun 29, 2023 · 5 comments
Closed

Devcontainer from docker hub #1421

stefjoosten opened this issue Jun 29, 2023 · 5 comments

Comments

@stefjoosten
Copy link
Contributor

Problem

To build the devcontainer for VS-code takes over an hour. As a result, I don't use it. When I need to do something in Ampersand I just don't find the time to wait for the devcontainer to build. Yet, I do want to use all the goodies that @hanjoosten has built.

Desired solution

As a developer, I want the devcontainer image to reside on docker-hub, so I merely have to wait for loading.

@stefjoosten
Copy link
Contributor Author

Solution

I have made the docker file in the .devcontainer directory merely import the correct image.
We then need to publish that image by means of a github action, so that the most recent image is always available.

@hanjoosten
Copy link
Member

@stefjoosten , we already had a branch that contain this work. You created a branch from development branch, which you should delete!
There is a PR (#1423) now, to get this stuff into main asap.

@hanjoosten
Copy link
Member

After #1423 has been merged, we still need a way to automatically update dockerhub.

@stefjoosten
Copy link
Contributor Author

stefjoosten commented Jul 22, 2023

There is a complication. When stack is building Ampersand, it calls GitHub to obtain a version number. It needs a pair of SSH keys to get access to the Ampersand repo. That is why stack build failed in the container. However, I don't like putting an SSH key pair into the repo because the repo is visible to the world.

So how do we do this? Here

@hanjoosten
Copy link
Member

Fixed by todays PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants