-
-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement SQL String functions with documentations #13
Comments
I am on ASCII |
I am on CHAR |
@AmrDeveloper , the CHARINDEX function might be tricky since the last argument is optional, but the condition checks if the specified arguments match, I mean here . |
I am on DATALENGTH. |
You are right some functions we will delay them until do some improvements in type system |
I am on LEFT |
@AmrDeveloper, is there a difference between the implementation of |
You are right, we can ignore it for now and maybe if needed we can pass the the char function to it |
Yeahh, that was I planned on doing, wanted to get your approval on it. |
I am on PATINDEX |
I faced the same problem in Date functions too we need to decide if we should duplicate them or take only one |
We could just use different names for them but they'll still be the same function. What I mean is: map.insert("char", text_char);
map.insert("nchar", text_char); And we do the same in the |
I am on REPLACE |
I am on RIGHT |
I am on STUFF |
I am on SUBSTRING |
I am on TRANSLATE |
@Lilit0x Lets keep next PR one by one it will be fast to review and merge |
Okay, got it. |
I am on SOUNDEX |
I am on CONCAT |
For Issue AmrDeveloper#13. cargo fmt
I am on UNICODE |
I am on CHARINDEX |
Hello @AmrDeveloper how do we handle optional arguments ? |
@mobley-trent Optional type is not implemented yet, i just implemented Variant and will implement Option soon |
@mobley-trent Now support Optional and varargs types |
@AmrDeveloper |
I am on QUOTENAME |
add `quotename` string function #13
Implement string function in our engine, one per pull request.
Steps:
I am on <function_name>
.crates/gitql-ast/function.rs
.docs/function/function.md
.Text Functions
For more information about implementation and description check https://www.w3schools.com/sql/sql_ref_sqlserver.asp
Note: You can only open max 3 PR at the time
The text was updated successfully, but these errors were encountered: