forked from wangqr/Aegisub
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
.github/workflows/gha-ci.yml: add assrender, download xy-vsf and vsfm…
…od separately
- Loading branch information
Showing
1 changed file
with
13 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d5c132aThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Latest vsfiltermod here:
https://github.com/computerfan/VSFilterMod/releases
d5c132aThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know this, but I don’t need new mod asstags for now.
d5c132aThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh, but your ver had issue after apply karaoke template
Runtime error in template code: Expected 1 arguments, got 2
Code producing error: ci = { 0,0 }; cn = _G.unicode.len(orgline.text_stripped:gsub(" ",""))
Upstream ver don't had this error.
My file sub: https://mega.nz/file/15h3SAaL#ssV3j4zU5AcJmBPM39s3Fm6FKMGGf6V9ukS6Vdvi9zw
d5c132aThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the error information, we will check it.
d5c132aThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kedaitinh12
I tried aegisub wangqr fork 3.3.3 and it has the same error when apply, I wonder if you can provide specific version information.
d5c132aThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That ver
https://github.com/Aegisub/Aegisub/releases
d5c132aThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kedaitinh12
I found this issue: Aegisub#96, all of the latest builds now have this issue, maybe something has changed in lua.
You can use
_G.unicode.len((orgline.text_stripped:gsub(" ","")))instead of_G.unicode.len(orgline.text_stripped:gsub(" ",""))d5c132aThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But Kainote fixed it, can you base Kainote to fix it??
https://github.com/bjakja/Kainote
d5c132aThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The issue is "caused" by this commit (e3c60514cd#diff-06242792b0c4ad8019226b580d45811c7beb1c54afa4e832a2e9b4b4e5628831L70) which adds argument type checks for
_G.unicode.lenand others.In theory we can "fix" it by disabling the argument type check, but I'm not sure that's the way we should go.
The issue is that the code
_G.unicode.len(orgline.text_stripped:gsub(" ",""))has always been incorrect;_G.unicode.len()only takes one argument, butstring.gsubalways return two; You can add another pair of parentheses to force one argument as mentioned by @MIRIMIRIM above.d5c132aThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah ok
d5c132aThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you can remove argument type checks for _G.unicode.len in new commit cause i don't see any error if ignored it in old ver