Change Time Offset is very slow fix #1769

Analogy-LogViewer · Aug 25, 2023 · ddf19fd · ddf19fd
1 parent 6d0746a
commit ddf19fd
Show file tree

Hide file tree

Showing 6 changed files with 21 additions and 371 deletions.
diff --git a/Analogy.CommonControls/Managers/PagingManager.cs b/Analogy.CommonControls/Managers/PagingManager.cs
@@ -141,7 +141,7 @@ public DataRow AppendMessage(IAnalogyLogMessage message, string dataSource)
             try
             {
                 lockSlim.EnterWriteLock();
-                DataRow dtr = Utils.CreateRow(table, message, dataSource,Settings.TimeOffsetType,Settings.TimeOffset);
+                DataRow dtr = Utils.CreateRow(table, message, dataSource, Settings.TimeOffsetType, Settings.TimeOffset);
                 table.Rows.Add(dtr);
                 return dtr;
 
@@ -357,15 +357,7 @@ public void UpdateOffsets()
             lockSlim.EnterWriteLock();
             foreach (DataTable dataTable in pages)
             {
-                dataTable.BeginLoadData();
-                foreach (DataRow dataTableRow in dataTable.Rows)
-                {
-                    dataTableRow.BeginEdit();
-                    AnalogyLogMessage m = (AnalogyLogMessage)dataTableRow[Common.CommonUtils.AnalogyMessageColumn];
-                    dataTableRow["Date"] = Utils.GetOffsetTime(m.Date, Settings.TimeOffsetType, Settings.TimeOffset);
-                    dataTableRow.EndEdit();
-                }
-                dataTable.EndLoadData();
+                Utils.ChangeOffset(dataTable, Settings);
             }
             lockSlim.ExitWriteLock();
         }

diff --git a/Analogy.CommonControls/UserControls/LogMessagesUC.cs b/Analogy.CommonControls/UserControls/LogMessagesUC.cs
@@ -1034,13 +1034,7 @@ private void GridView_ShownEditor(object sender, System.EventArgs e)
         private void RefreshTimeOffset()
         {
             PagingManager.UpdateOffsets();
-            foreach (DataRow dataTableRow in _bookmarkedMessages.Rows)
-            {
-                dataTableRow.BeginEdit();
-                AnalogyLogMessage m = (AnalogyLogMessage)dataTableRow[Common.CommonUtils.AnalogyMessageColumn];
-                dataTableRow["Date"] = Utils.GetOffsetTime(m.Date, Settings.TimeOffsetType, Settings.TimeOffset);
-                dataTableRow.EndEdit();
-            }
+            Utils.ChangeOffset(_bookmarkedMessages, Settings);
         }
 
 

diff --git a/Analogy.CommonControls/UserControls/ServerSideLogMessagesUC.cs b/Analogy.CommonControls/UserControls/ServerSideLogMessagesUC.cs
@@ -826,13 +826,7 @@ private void GridView_ShownEditor(object sender, System.EventArgs e)
         private void RefreshTimeOffset()
         {
             PagingManager.UpdateOffsets();
-            foreach (DataRow dataTableRow in _bookmarkedMessages.Rows)
-            {
-                dataTableRow.BeginEdit();
-                AnalogyLogMessage m = (AnalogyLogMessage)dataTableRow[Common.CommonUtils.AnalogyMessageColumn];
-                dataTableRow["Date"] = Utils.GetOffsetTime(m.Date, Settings.TimeOffsetType, Settings.TimeOffset);
-                dataTableRow.EndEdit();
-            }
+            Utils.ChangeOffset(_bookmarkedMessages, Settings);
         }
 
 

diff --git a/Analogy.CommonControls/Utils.cs b/Analogy.CommonControls/Utils.cs
@@ -6,6 +6,7 @@
 using System.Runtime.CompilerServices;
 using System.Runtime.InteropServices;
 using Analogy.Common.DataTypes;
+using Analogy.Common.Interfaces;
 using Analogy.CommonControls.DataTypes;
 using Analogy.Interfaces;
 using Analogy.Interfaces.DataTypes;
@@ -114,6 +115,20 @@ public static DateTime GetOffsetTime(DateTime time, TimeOffsetType timeOffsetTyp
                 _ => time
             };
         }
+
+        public static void ChangeOffset(DataTable dataTable, IUserSettingsManager settings)
+        {
+            dataTable.BeginLoadData();
+            foreach (DataRow row in dataTable.Rows)
+            {
+                row.BeginEdit();
+                AnalogyLogMessage m = (AnalogyLogMessage)row[Common.CommonUtils.AnalogyMessageColumn];
+                row["Date"] = Utils.GetOffsetTime(m.Date, settings.TimeOffsetType, settings.TimeOffset);
+                row.EndEdit();
+                row.AcceptChanges();
+            }
+            dataTable.EndLoadData();
+        }
         [MethodImpl(MethodImplOptions.AggressiveInlining)]
         public static DataTable DataTableConstructor()
         {

diff --git a/Analogy/CommonChangeLog.cs b/Analogy/CommonChangeLog.cs
@@ -8,7 +8,8 @@ public static class CommonChangeLog
         public static IEnumerable<AnalogyChangeLog> GetChangeLog()
         {
             return new List<AnalogyChangeLog>
-            {
+            {    
+                new ("V5.0.0 - Change Time Offset is very slow #1769", AnalogChangeLogType.Bug,"Lior Banai",new DateTime(2023,08,25),"5.0.0.0"),
                 new ("V5.0.0 - Message viewer doesn't understand Linux-style new lines #1770", AnalogChangeLogType.Improvement,"Lior Banai",new DateTime(2023,08,25),"5.0.0.0"),
                 new ("V5.0.0 - Add Search everywhere checkbox #1812",AnalogChangeLogType.Improvement,"Lior Banai",new DateTime(2023,07,18), "5.0.0.0"),
                 new ("V5.0.0 - Add NET8 initial Support #1814",AnalogChangeLogType.Improvement,"Lior Banai",new DateTime(2023,07,18), "5.0.0.0"),