Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cylinder does not close #1093

Closed
pjcozzi opened this issue Aug 29, 2013 · 2 comments · Fixed by #1142
Closed

Cylinder does not close #1093

pjcozzi opened this issue Aug 29, 2013 · 2 comments · Fixed by #1142
Labels
type - bug

Comments

@pjcozzi
Copy link
Contributor

pjcozzi commented Aug 29, 2013

I thought we already had an issue, but I couldn't find it.

image

@hpinkos can you take a look?
@hpinkos
Copy link
Contributor

hpinkos commented Aug 29, 2013

@pjcozzi I looked at this a while ago, and it's not related to anything in CylinderGeometry. The positions and indices are correct. The triangles are drawn correctly if you use the same geometry in a second instance. I'm guessing it might be happening somewhere in the GeometryPipeline, but I really have no idea. @bagnell said he would look into it when we talked about it a while ago. I think this is caused by the same issue:
image

@evax
Copy link
Contributor

evax commented Aug 29, 2013

@pjcozzi I noticed this too in the Circle and Ellipse Sandcastle demo for the Outline Circle:
circle_outline_not_closed

@hpinkos hpinkos mentioned this issue Sep 6, 2013
Merged
@bagnell bagnell mentioned this issue Sep 11, 2013
Merged
@pjcozzi pjcozzi mentioned this issue Sep 12, 2013
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type - bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Missing Triangles CesiumGS/cesium
3 participants
@evax @pjcozzi @hpinkos