Missing Triangles #1142
Merged
Missing Triangles #1142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I updated CHANGES.md. Please remember it next time. I also made a few similar changes elsewhere. Less is more so I dig this, but I don't get why it works. This fixes the cylinder, but not the ellipse. I'll make a separate issue for that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #1093. Makes
Cartesian*.fromArrayan alias ofCartesian*.unpack.@shunter found that this line was the problem:
result.x = values[offset + 0];.To fix the problem, change it to:
result.x = values[offset];.This was causing
NaNs to show up in typed arrays.