Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

3D tiles interactivity sandcastle example throws developer error #5703

Closed
hpinkos opened this issue Jul 31, 2017 · 2 comments
Closed

3D tiles interactivity sandcastle example throws developer error #5703

hpinkos opened this issue Jul 31, 2017 · 2 comments
Labels
category - sandcastle good first issue An opportunity for first time contributors type - bug

Comments

@hpinkos
Copy link
Contributor

hpinkos commented Jul 31, 2017

http://cesiumjs.org/Cesium/Apps/Sandcastle/index.html?src=3D%20Tiles%20Interactivity.html&label=All

This is easiest to reproduce in Firefox. Sometimes pickPosition returns undefined, and the annotation part of the example throws a DeveloperError when we call Cesium.Cartographic.fromCartesian. We need to check if cartesian is defined before continuing
@hpinkos hpinkos added good first issue An opportunity for first time contributors category - sandcastle type - bug labels Jul 31, 2017
@chris-cooper chris-cooper mentioned this issue Aug 2, 2017
Closed
@esraerik esraerik mentioned this issue Aug 17, 2017
Merged
@klim705
Copy link
Contributor

klim705 commented Jan 2, 2018

This was fixed in #5759.

@pjcozzi
Copy link
Contributor

pjcozzi commented Jan 2, 2018

Good eye, thanks @klim705!

@pjcozzi pjcozzi closed this as completed Jan 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
category - sandcastle good first issue An opportunity for first time contributors type - bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@pjcozzi @hpinkos @klim705