added cartesian defined control, changes.md updated #5759
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ggetz
requested changes
Aug 22, 2017
| @@ -45,7 +45,6 @@ | |||
| 'use strict'; | |||
| //Sandcastle_Begin | |||
| var viewer = new Cesium.Viewer('cesiumContainer'); | |||
|
|
|||
CHANGES.md
Outdated
| @@ -1,5 +1,9 @@ | |||
| Change Log | |||
| ========== | |||
| ### 1.36 - 2017-08-17 | |||
There was a problem hiding this comment.
This will be 1.37 - 2017-09-01. It's not a breaking change, so no need to list it as one. Usually we say something like Fixed a bug where developer error was thrown in Sandcastle example [#5703](https://github.com/AnalyticalGraphicsInc/cesium/issues/5703)
Added whitespace
ggetz
requested changes
Aug 22, 2017
| @@ -45,7 +45,7 @@ | |||
| 'use strict'; | |||
| //Sandcastle_Begin | |||
| var viewer = new Cesium.Viewer('cesiumContainer'); | |||
|
|
|||
There was a problem hiding this comment.
@esraerik This tab shouldn't be here either.
…cartesian-defined-control # Conflicts: # Apps/Sandcastle/gallery/3D Tiles Interactivity.html
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#5703 In 3D Tiles Interactivity sandcastle added cartesian is defined control. So prevent developer error caused in annotate example.