Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better mouse controls for untracking entity #5959

Closed
SkinnyRat opened this issue Nov 2, 2017 · 9 comments
Closed

Better mouse controls for untracking entity #5959

SkinnyRat opened this issue Nov 2, 2017 · 9 comments

Comments

@SkinnyRat
Copy link

SkinnyRat commented Nov 2, 2017

Before double-clicking on a GLTF object or similar, the controls are:
Left-click => Pan
Scroll-click => Rotate

After double-clicking, the controls get changed to:
Left-click => Rotate
Scroll-click => Disabled

Cesium version: 1.39
To replicate: Visit the sandcastle & double-click on the truck.
https://cesiumjs.org/Cesium/Build/Apps/Sandcastle/index.html?src=Physically-Based%20Materials.html&label=Showcases

My system: FireFox 54.0 (64-bit) on Ubuntu 16.04

Thanks!

@ggetz
Copy link
Contributor

ggetz commented Nov 2, 2017

Hi @SkinnyRat, thanks for the report!

Setting viewer.trackEntity = undefined restores the controls, so I assume the gltf object is still be tracked after clicking away. Is that intended behavior?

@hpinkos hpinkos changed the title Mouse controls bug? Better mouse controls for untracking entity Nov 2, 2017
@hpinkos
Copy link
Contributor

hpinkos commented Nov 2, 2017

@SkinnyRat The behavior you're seeing is intended, but I agree that we can probably improve this interaction. As far as I know, clicking the home button is the best way to un-track an entity after you double click it. Maybe we can remove the tracked entity when you double click away from it.

In the meantime, if you want to disable the double click behavior, you can do so with this line:
viewer.screenSpaceEventHandler.removeInputAction(Cesium.ScreenSpaceEventType.LEFT_DOUBLE_CLICK);

@shunter
Copy link
Contributor

shunter commented Nov 2, 2017

The top-left button on the info box also un-tracks a tracked entity.

@SkinnyRat
Copy link
Author

Ah I see... disabling double-clicks works for me.
Thanks!

@OmarShehata
Copy link
Contributor

@hpinkos should this be re-opened? It's pretty unintuitive as it is right now. I also thought it was a bug, and it came up on the forum again here:

https://groups.google.com/d/msg/cesium-dev/EIRyiQR5_fY/WENhsMl5AgAJ

@hpinkos hpinkos reopened this Sep 4, 2018
@hpinkos
Copy link
Contributor

hpinkos commented Sep 4, 2018

I think double clicking off of the entity would be an intuitive way to unset the tracked entity. @mramato @emackey what do you think?

@GatorScott
Copy link

double-click might be better since the user won't have to know what's not clickable, especially for new users of an application. e.g. Double-clicking the sky box or the globe might give coordinates of the clicked location.

@hpinkos
Copy link
Contributor

hpinkos commented Sep 4, 2018

right, and they have to double click the entity right now to track it, so double clicking away from it seems like a natural choice

@cesium-concierge
Copy link

Congratulations on closing the issue! I found these Cesium forum links in the comments above:

https://groups.google.com/d/msg/cesium-dev/EIRyiQR5_fY/WENhsMl5AgAJ

If this issue affects any of these threads, please post a comment like the following:

The issue at #5959 has just been closed and may resolve your issue. Look for the change in the next stable release of Cesium or get it now in the master branch on GitHub https://github.com/AnalyticalGraphicsInc/cesium.


I am a bot who helps you make Cesium awesome! Contributions to my configuration are welcome.

🌍 🌎 🌏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants