Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Untrack entity when double-clicking away #7285

Merged
merged 4 commits into from
Dec 27, 2018

Conversation

adridavid
Copy link
Contributor

Fixes #5959

This modifies the viewer default input action for the LEFT_DOUBLE_CLICK event type.
If an entity is being tracked by the viewer, double-clicking away from it (except on another entity) will untrack the entity.

@cesium-concierge
Copy link

Thank you so much for the pull request @adridavid! I noticed this is your first pull request and I wanted to say welcome to the Cesium community!

The Pull Request Guidelines is a handy reference for making sure your PR gets accepted quickly, so make sure to skim that.

  • ❌ Missing CONTRIBUTORS.md entry.
  • ❌ Missing CLA.
  • CHANGES.md was not updated.
    • If this change updates the public API in any way, please add a bullet point to CHANGES.md.

Reviewers, don't forget to make sure that:

  • Cesium Viewer works.
  • Works in 2D/CV.
  • Works (or fails gracefully) in IE11.

I am a bot who helps you make Cesium awesome! Contributions to my configuration are welcome.

🌍 🌎 🌏

@pjcozzi
Copy link
Contributor

pjcozzi commented Nov 28, 2018

Thanks again @adridavid, we received your CLA.

@hpinkos
Copy link
Contributor

hpinkos commented Dec 27, 2018

Thanks @adridavid! This is a change I've wanted to make for a while.

@hpinkos hpinkos merged commit bb8e7c4 into CesiumGS:master Dec 27, 2018
@hpinkos
Copy link
Contributor

hpinkos commented Dec 27, 2018

Added a note to CHANGES here: d6c7110

@emackey
Copy link
Contributor

emackey commented Dec 28, 2018

This is a good change, thanks @adridavid and @hpinkos

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants