Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable GroundPrimitives to render without the fragment depth extension. #4930

Merged
merged 4 commits into from
Feb 1, 2017

Conversation

bagnell
Copy link
Contributor

@bagnell bagnell commented Jan 27, 2017

Fixes #4899.

@bagnell
Copy link
Contributor Author

bagnell commented Jan 27, 2017

Because we can't write depth to clamp fragments to the far plane, there is an artifact when any of the far planes of the multi-frustum intersect terrain and the volume.

@pjcozzi
Copy link
Contributor

pjcozzi commented Feb 1, 2017

Update CHANGES.md (for 1.31, not 1.30) and the reference doc.

@bagnell
Copy link
Contributor Author

bagnell commented Feb 1, 2017

@pjcozzi Updated.

@mramato
Copy link
Contributor

mramato commented Feb 1, 2017

This is awesome! Extremely preferable to what we had before. Hopefully users will think so too. While there are definitely some artifacts, they are way less common than I thought and I think will not even be a problem in most casas.

@pjcozzi approved this for merge offline and it will have a whole month to stew in master if there are unforeseen problems

@mramato mramato merged commit e2c5ccc into master Feb 1, 2017
@mramato mramato deleted the ground-primitive-no-frag-depth branch February 1, 2017 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants