Merge pull request #243 from AnandChowdhary/typescript

♻️ Use fetch endpoint function
AnandChowdhary · Aug 13, 2019 · 8251759 · 8251759
2 parents 52bfc46 + 7558d24
commit 8251759
Show file tree

Hide file tree

Showing 5 changed files with 9 additions and 8 deletions.
diff --git a/docs/index.js b/docs/index.js
diff --git a/docs/interfaces.d.ts b/docs/interfaces.d.ts
@@ -3,7 +3,7 @@ export interface Settings {
     template?: (result?: TextResult) => string;
     wikipediaLanguage?: string;
     noCache?: boolean;
-    fetchEndpoint?: string;
+    getFetchEndpoint?: (word: string) => string;
     fetchConfig?: any;
     storage?: {
         getItem(key: string): string;

diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "hovercard",
-  "version": "2.0.0",
+  "version": "2.0.1",
   "description": "Hover summary cards for the web",
   "main": "docs/index.js",
   "module": "docs/index.js",

diff --git a/src/index.ts b/src/index.ts
@@ -163,9 +163,10 @@ export default class Hovercard extends TypeStart {
     if (typeof this.settings.getData === "function")
       result = await this.settings.getData(word);
     const fetched = await fetch(
-      this.settings.fetchEndpoint ||
-        `https://${this.settings.wikipediaLanguage ||
-          "en"}.wikipedia.org/api/rest_v1/page/summary/${encode(word)}`,
+      typeof this.settings.getFetchEndpoint === "function"
+        ? this.settings.getFetchEndpoint(word)
+        : `https://${this.settings.wikipediaLanguage ||
+            "en"}.wikipedia.org/api/rest_v1/page/summary/${encode(word)}`,
       this.settings.fetchConfig
     );
     if (fetched.status >= 300) throw new Error(fetched.statusText);

diff --git a/src/interfaces.ts b/src/interfaces.ts
@@ -3,7 +3,7 @@ export interface Settings {
   template?: (result?: TextResult) => string;
   wikipediaLanguage?: string;
   noCache?: boolean;
-  fetchEndpoint?: string;
+  getFetchEndpoint?: (word: string) => string;
   fetchConfig?: any;
   storage?: {
     getItem(key: string): string;