chore: add E2E test for Vite #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
layershifter
force-pushed
the
test/e2e-vite
branch
3 times, most recently
from
82dc9e1 to
8322e7d
Compare
layershifter
commented
Dec 15, 2023
| @@ -20,6 +20,7 @@ | |||
| "@wyw-in-js/ts-config": "workspace:*", | |||
| "dedent": "^1.5.1" | |||
| }, | |||
| "main": "src/index.ts", | |||
There was a problem hiding this comment.
Used to satisfy a resolver in Vite. As the package is private, it's not an issue.
layershifter
commented
Dec 15, 2023
Comment on lines
+63
to
+64
| "clean": "del '{e2e,examples,packages}/*/{coverage,dist,esm,lib,types,tsconfig.tsbuildinfo}'", | ||
| "idea-exclude:artifacts": "idea-exclude artifacts \"{configs,e2e,examples,packages}/*/{.turbo,esm,lib,types}\"", |
There was a problem hiding this comment.
Updated to clean and exclude new dirs.
Anber
approved these changes
Jan 8, 2024
layershifter
force-pushed
the
test/e2e-vite
branch
from
8322e7d to
a59e048
Compare
Anber
approved these changes
Jan 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a simple E2E test for Vite to ensure that CSS gets build properly.