Add onDismiss closure to public ViewModifier #175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
@AndreaMiotto are you still maintaining this repo? Looks like there hasn't been a release or successful merge in over a year. |
|
Hi @AndreaMiotto just pinging you again re: my previous message. |
|
@AndreaMiotto please see above comments |
|
@AndreaMiotto are you still actively maintaining this repo? |
|
@AndreaMiotto please see above ^ |
|
@AndreaMiotto hello? |
1 similar comment
|
@AndreaMiotto hello? |
|
@AndreaMiotto I'll give it a shot too, as a onDismiss is pretty necessary for my things. |
|
@Lucrecious I suspect the repo has been abandoned; it's been so long since there has been any kind of update -- over a year. It may make sense at this point to just fork the repo and copy the changes over if you'd like. |
AndreaMiotto
approved these changes
Aug 30, 2023
|
Hey 👋🏻 Thanks for merging @AndreaMiotto 😁 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Iterations prior to the 3.0 variant of the framework provided an
onDismissclosure.3.0+ removed public ability to set this parameter despite the property existing internally.
This change adds
onDismissback to the public facingViewModifier.