Migrate from @hapi/joi to joi #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alex996
reviewed
Jul 22, 2020
| @@ -33,7 +33,7 @@ | |||
| "middleware" | |||
| ], | |||
| "dependencies": { | |||
| "@hapi/joi": "17.x.x", | |||
| "joi": "17.x.x", | |||
| "@types/express": "4.x.x", | |||
| "@types/hapi__joi": "16.x.x" | |||
There was a problem hiding this comment.
Shouldn't this change to @types/joi? We may need to wait until it gets in sync with the last release of joi
There was a problem hiding this comment.
Yup, should probably jump "@types/hapi__joito@types/joi`. But as you mentioned it still hasn't caught up, so that's probably another, later, Pull Request.
This PR should be mergeable now, and would remove the deprecation warning at npm/yarn install time.
There was a problem hiding this comment.
Re: @types/joi, there is a PR to update the types DefinitelyTyped/DefinitelyTyped#46241 but it looks like the progress has stalled.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hapijs/joi#2411