-
Notifications
You must be signed in to change notification settings - Fork 127
Conversation
Okay, we'll need to update tests. |
A couple of things I've encountered while updating Jest with this new setup. (Still not finished).
Still figuring this one. |
Found a possible solution to item 1 here jestjs/jest#1468 (comment). |
Interestingly when googling around I found some tickets from people who had the opposite problem: Their .babelrc not being read, so they had to use babel.config.js instead. Anyways, I don't think that we can use .babe.rc since it's just a JSON file. Our setup determines the different presets, etc. to use programmatically at build time using the JavaScript in babel.config.js. Is this section of the documentation of any help? https://jestjs.io/docs/en/getting-started.html#using-babel
Looking at the Enzyme type definition, it doesn't look like Enzyme actually has a default export. Does using |
Setting useESModules to |
This is awesome! With the transformer we are actually able to re-use our existing babel.config, allowing us to keep configuration babel in a single place. |
I think we are good place now. Free free to add items to the CHANGELOG.md, possible update README and/or github wiki. |
I'm ready to merge at this point.
Sounds good! 👍 |
Webpack is meant for the final bundling of a code base. Libraries are better built using raw Babel.
See #31 for details & discussion.