it doesn't make sense to return empty partition, 'out_of_range' excep…

…tion is better
AndreyG · Oct 5, 2023 · 1906ccf · 1906ccf
1 parent ecf9816
commit 1906ccf
Showing 1 changed file with 2 additions and 6 deletions.
diff --git a/lib/core/src/File.cpp b/lib/core/src/File.cpp
@@ -248,16 +248,12 @@ namespace ifc
                 auto partition = *cached_partition;
                 return { static_cast<T const*>(partition.data), partition.size };
             }
-            else if (auto it = table_of_contents_.find(name); it != table_of_contents_.end())
+            else
             {
-                auto result = get_partition<T, Index>(it->second);
+                auto result = get_partition<T, Index>(table_of_contents_.at(name));
                 cached_partition.emplace(result.data(), result.size());
                 return result;
             }
-            else
-            {
-                return Partition<T, Index>{nullptr, 0};
-            }
         }
 
         std::unordered_map<DeclIndex, std::vector<AttrIndex>> const & trait_declaration_attributes()