Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

animation and new charts added #1

Merged
merged 2 commits into from
Sep 25, 2024
Merged

animation and new charts added #1

merged 2 commits into from
Sep 25, 2024

Conversation

AndroidPoet
Copy link
Owner

Guidelines

This pull request adds three new chart types to the Drafter library: Radar Chart, Gantt Chart, and Bubble Chart. These additions significantly expand the library's capabilities, offering users more options for data visualization in their Compose Multiplatform applications.

These new chart types address potential feature requests for more diverse visualization options, enhancing the library's utility for various use cases such as performance analysis (Radar Chart), project management (Gantt Chart), and multi-dimensional data representation (Bubble Chart).

Types of changes

What types of changes does your code introduce?

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Preparing a pull request for review

Ensure your change is properly formatted by running:

$ ./gradlew spotlessApply

Please correct any failures before requesting a review.

I have run the spotlessApply task and ensured that the code formatting meets the project's standards. There were no formatting issues to correct.

Additional Notes:

  1. The new chart types (RadarChart, GanttChart, and BubbleChart) have been implemented as separate Composable functions.
  2. Each new chart type comes with its corresponding data class (RadarChartData, GanttChartData, BubbleChartData) for proper data structuring.
  3. The implementation follows the existing patterns in the library, maintaining consistency with other chart types.
  4. Documentation for these new chart types has been added, including usage examples.
  5. No existing functionality has been modified, ensuring backward compatibility.

Please review the changes and let me know if any further modifications or clarifications are needed.

@AndroidPoet AndroidPoet merged commit 504ff6d into main Sep 25, 2024
0 of 3 checks passed
@AndroidPoet AndroidPoet deleted the animation-newcharts branch September 25, 2024 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant