Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

access status after evaluating response #6

Merged
merged 1 commit into from
May 22, 2024

Conversation

joprice
Copy link
Contributor

@joprice joprice commented May 18, 2024

This addresses #5 by moving the computation of status and content type until after the handler promise has completed, since that promise may have asynchronous mutations to the context that change these fields.

I also added a module statement to the sample Worker to fix an error hit from a build (likely a stricter compiler error in more recent fsharp versions).

Copy link
Owner

@AngelMunoz AngelMunoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there! thanks for taking a look at this give me a chance to check it over the weekend (or maybe over half the next week) to get it released!

The change makes sense I don't know why I didn't catch this when I was doing it

@AngelMunoz AngelMunoz merged commit c5aa89d into AngelMunoz:main May 22, 2024
@joprice joprice deleted the fixStatus branch May 22, 2024 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants