Bump inquirer and inquirer-autocomplete-prompt #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Anifacted
approved these changes
Dec 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Earlier versions of Inquirer.js seem to suffer from issues (For example, SBoudrias/Inquirer.js#752, SBoudrias/Inquirer.js#792) that cause hanging on Node 10+ and Windows 10.
On my dev machine (Windows 10 Version 1903, Node v10.16.0, lerna-update-wizard v0.17.5), running
npx lernaupdatewill hang after selecting a dependency to upgrade:When using locally pinned
inquirer@7.0.0andinquirer-autocomplete-prompt@1.0.1, things will run properly.I also ran into the numerous errors mentioned at #35 (comment) after
npm test. Not sure I have enough time or knowledge to fix it though.