Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Symfony requirement to 4.4.X #6

Merged
merged 2 commits into from
Feb 27, 2020
Merged

Conversation

fuegas
Copy link
Contributor

@fuegas fuegas commented Jan 25, 2020

As 5.X is the stable branch and 4.4 the LTS I've changed the requirements to make an update to the 4.X libraries we use easier.

This update should resolve the vulnerabilities in PR #2, #3, #4 and #5.

As there is no testsuite it's a bit hard for me to see if the changes have a negative side-effect. Could you shed some light on this @janvernieuwe ? Or test it? :)

As 5.X is the stable branch and 4.4 the LTS I've changed the requirements to make an update to the 4.X libraries we use easier.

This update should resolve the vulnerabilities in PR #2, #3, #4 and #5.
@janvernieuwe
Copy link
Member

Minor upgrades should be fine.
But some test definitely are a must, I'll look into adding some and add them to the CI.

@janvernieuwe janvernieuwe merged commit e1847e0 into master Feb 27, 2020
@janvernieuwe
Copy link
Member

Thanks for the PR!

Thinking about upgrading to SF5

@fuegas fuegas deleted the update-to-symfony-4.4 branch February 27, 2020 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants