Fix visibility filter for activity #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beverloo
approved these changes
Sep 6, 2023
There was a problem hiding this comment.
Changing the visibility filter from a search filter to a boolean filter LGTM - the former exists for strings which definitely isn't the right mechanism.
It's not entirely clear to me how this would fix #38 (if that's the intention), unless there are filters that are applied by default?
|
what uri are you using? the public api had pre-set filters indeed |
|
Ah, where are those defined? I issue requests to https://animecon.nl/api/rest/activities.json |
|
That uri should be fine |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.