-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix visibility filter for activity #40
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changing the visibility filter from a search filter to a boolean filter LGTM - the former exists for strings which definitely isn't the right mechanism.
It's not entirely clear to me how this would fix #38 (if that's the intention), unless there are filters that are applied by default?
what uri are you using? the public api had pre-set filters indeed |
Ah, where are those defined? I issue requests to https://animecon.nl/api/rest/activities.json |
That uri should be fine |
No description provided.