Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SSL support to mesos configuration #77

Merged
merged 1 commit into from
Jan 30, 2017

Conversation

veger
Copy link
Contributor

@veger veger commented Jan 24, 2017

This PR adds SSL-related configuration settings in /etc/default/mesos when mesos_ssl_enabled is true.

@veger
Copy link
Contributor Author

veger commented Jan 24, 2017

CentOS 7 task Downloading and enable the EPEL repository definitions. fails

@@ -8,6 +8,15 @@ LOGS={{mesos_log_location}}
ULIMIT="{{mesos_ulimit}}"
ZK="{{ mesos_zookeeper_masters }}"

{% if mesos_ssl_enabled %}
export LIBPROCESS_SSL_ENABLED=true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't this be prefixed with MESOS_ ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have it currently working using exactly this.
If you like I can check tomorrow if the MESOS_ prefix also works?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried MESOS_LIBPROCESS_SSL_ENABLED and MESOS_SSL_ENABLED, both do not work

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thats odd but ok, will check why build fails

@ernestas-poskus
Copy link
Member

Rebase on master, fixed in #78

@ernestas-poskus
Copy link
Member

Thank you for contribution 👍

@ernestas-poskus ernestas-poskus merged commit b52ffab into AnsibleShipyard:master Jan 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants