Adding S3 support. #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jlm3575
commented
May 9, 2017
| stat: path={{zookeeper_tarball_dir}}/zookeeper-{{zookeeper_version}}.tar.gz | ||
| register: zookeeper_tarball_script | ||
|
|
||
| - name: Download zookeeper from S3 |
There was a problem hiding this comment.
Provide the option of storing the tarball in Amazon S3.
jlm3575
commented
May 9, 2017
| when: > | ||
| zookeeper_archive_s3_bucket is defined and | ||
| zookeeper_archive_s3_object is defined and | ||
| not zookeeper_tarball_script.stat.exists |
There was a problem hiding this comment.
We have to make sure all vars are defined, and that the tarball hasn't already been downloaded. The S3 directive will fail in some cases if the file exists.
jlm3575
commented
May 9, 2017
| - name: Download zookeeper version. | ||
| get_url: url={{zookeeper_url}} dest={{zookeeper_tarball_dir}}/zookeeper-{{zookeeper_version}}.tar.gz | ||
| tags: bootstrap | ||
| register: zookeeper_tarball_downloaded | ||
| when: > | ||
| zookeeper_archive_s3_bucket is not defined or |
There was a problem hiding this comment.
If they missed either var, download from Apache.
|
Hi please rebase on master, build is now fixed with #67 |
jlm3575
force-pushed
the
jlm3575/s3-support
branch
from
8a29045 to
dc54ad7
Compare
|
@ernestas-poskus, rebased. |
|
LGTM, thank you contribution |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.