Enable systemd service for Debian 8 #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ernestas-poskus
requested changes
Jun 14, 2017
defaults/main.yml
Outdated
| @@ -4,7 +4,7 @@ zookeeper_url: http://www.us.apache.org/dist/zookeeper/zookeeper-{{zookeeper_ver | |||
|
|
|||
| # Flag that selects if systemd or upstart will be used for the init service: | |||
| # Note: by default Ubuntu 15.04 and later use systemd (but support switch to upstart) | |||
| zookeeper_debian_systemd_enabled: "{{ ansible_distribution_version|version_compare(15.04, '>=') }}" | |||
| zookeeper_debian_systemd_enabled: "{{ ansible_distribution_version|version_compare(15.04, '>=') or ansible_distribution_version|version_compare(8.0, '>=') }}" | |||
There was a problem hiding this comment.
now this check includes all versions from 8.0 please change or condition to or (debian and version >= 8.0)
Currently, when running ansible-zookeeper role on Debian 8 host, it
fails:
TASK [AnsibleShipyard.ansible-zookeeper : Enable zookeeper service] ***************************************************
fatal: [debian8-host]: FAILED! => {"changed": false, "failed": true, "msg": "Could not find the requested service zookeeper: host"}
This happens because `zookeeper_debian_systemd_enabled` variable is
enabled only for Ubuntu >= 15.04 hosts.
This PR adds check for Debian >= 8.0, so Zookeeper successfully installs
on Debian 8.0
dzeban
force-pushed
the
enable-systemd-debian8
branch
from
9fff4b4 to
eb88708
Compare
|
@ernestas-poskus Good catch! Sorry for my sloppiness - I've fixed version compare. It's now a bit more verbose but more robust - it checks versions for Ubuntu and Debian separately. If it seems complicated I can put the comparison inside |
Yes looks very good !
Reads better now, I like extra underscore in front 👍 |
ernestas-poskus
approved these changes
Jun 15, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when running ansible-zookeeper role on Debian 8 host, it
fails:
This happens because
zookeeper_debian_systemd_enabledvariable isenabled only for Ubuntu >= 15.04 hosts.
This PR adds check for Debian >= 8.0, so Zookeeper successfully installs
on Debian 8.0