Extracted hardcoded zookeeper ports into vars #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ernestas-poskus
approved these changes
Dec 15, 2017
There was a problem hiding this comment.
@RunsFor hey, bumped zookeeper version because tests were broken, please rebase on master and I will merge this
|
Kudos for tests 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This playbook helped me a lot. That was just a little issue, that I could not setup custom ports for peer to peer node communication.
It was hardcoded to
2888:3888. On my servers setup these ports are not accessible, so I needed to use another. I think that option to override those ports may be usefull.Thanks!