Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(aggregation-api)!: add new endpoint for economy/mc-all aggregation #2092

Merged
merged 19 commits into from
Aug 27, 2024

Conversation

mabw-rte
Copy link
Contributor

Context:
for the aggregation apis, we want to add additional endpoints that perform aggregation on the folder economy/mc-all

@mabw-rte mabw-rte self-assigned this Jul 15, 2024
@mabw-rte mabw-rte force-pushed the feature/1886-mc-all-aggregation branch from 8c238fb to 59f1349 Compare July 16, 2024 19:22
Copy link
Contributor

@MartinBelthle MartinBelthle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see the part concerning the regex for column names (see JIRA issue).
You should add and test it.
Also, for mc-all, there are new type of files that can be requested (see JIRA issue) so you need to implement that.

@mabw-rte mabw-rte force-pushed the feature/1886-mc-all-aggregation branch from 59f1349 to bb87d73 Compare July 31, 2024 21:45
@mabw-rte mabw-rte force-pushed the feature/1886-mc-all-aggregation branch 3 times, most recently from 4c272cf to a64eb0a Compare August 6, 2024 19:38
Copy link
Contributor

@MartinBelthle MartinBelthle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't read everything but overall the code is super complex and it's really hard to understand your logic so could you add some doc inside the code to make it more readable and maintainable.

antarest/study/web/raw_studies_blueprint.py Outdated Show resolved Hide resolved
antarest/study/web/raw_studies_blueprint.py Outdated Show resolved Hide resolved
antarest/study/service.py Outdated Show resolved Hide resolved
antarest/study/business/aggregator_management.py Outdated Show resolved Hide resolved
antarest/study/business/aggregator_management.py Outdated Show resolved Hide resolved
antarest/study/business/aggregator_management.py Outdated Show resolved Hide resolved
antarest/study/business/aggregator_management.py Outdated Show resolved Hide resolved
@mabw-rte mabw-rte force-pushed the feature/1886-mc-all-aggregation branch 4 times, most recently from 0b81083 to 93a59a6 Compare August 20, 2024 21:50
antarest/study/business/aggregator_management.py Outdated Show resolved Hide resolved
antarest/study/business/aggregator_management.py Outdated Show resolved Hide resolved
antarest/study/business/aggregator_management.py Outdated Show resolved Hide resolved
antarest/study/business/aggregator_management.py Outdated Show resolved Hide resolved
antarest/study/business/aggregator_management.py Outdated Show resolved Hide resolved
antarest/study/business/aggregator_management.py Outdated Show resolved Hide resolved
@mabw-rte mabw-rte force-pushed the feature/1886-mc-all-aggregation branch from bce3afa to 1d0b944 Compare August 22, 2024 18:59
Copy link
Member

@sylvlecl sylvlecl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We must not merge this before making sure the API breaking change is intended and documented in the changelog.

antarest/study/web/raw_studies_blueprint.py Show resolved Hide resolved
@mabw-rte mabw-rte force-pushed the feature/1886-mc-all-aggregation branch from 1d0b944 to 8416433 Compare August 26, 2024 12:07
@mabw-rte mabw-rte changed the title feat(aggregation-api): add new endpoint for economy/mc-all aggregation feat(aggregation-api)!: add new endpoint for economy/mc-all aggregation Aug 27, 2024
@MartinBelthle MartinBelthle self-requested a review August 27, 2024 09:16
@mabw-rte mabw-rte merged commit aa2216a into dev Aug 27, 2024
10 checks passed
@mabw-rte mabw-rte deleted the feature/1886-mc-all-aggregation branch August 27, 2024 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants