feat(installer): add installer as a submodule #2110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skamril
previously approved these changes
Aug 6, 2024
skamril
force-pushed
the
feature/add-installer-submodule
branch
from
11b6cae
to
b01bb27
Compare
… into feature/add-installer-submodule
… into feature/add-installer-submodule # Conflicts: # installer
maugde
force-pushed
the
feature/add-installer-submodule
branch
from
4813c0b
to
d59efea
Compare
sylvlecl
requested changes
Aug 21, 2024
There was a problem hiding this comment.
The script does not work as intended because we mix dependencies for the server with dependencies for the installer, therefore we get an invalid server executable.
Note that to validate the workflow behaviour you can add this branch in the "on: push: branches" list in deploy.yml. This way we'll be able to download the generated artifacts from the actions page.
… into feature/add-installer-submodule
sylvlecl
reviewed
Aug 22, 2024
This allows to remove an unnecessary trick from CI, which could break if anything change on github side. Signed-off-by: Sylvain Leclerc <sylvain.leclerc@rte-france.com>
Uses antares-timeseries-generation to perform thermal clusters timeseries generation. The generation is performed as a background task on file studies, since it can take several seconds or more. Note that generated matrices are not "inner matrices" of the command since they are generated on each command execution. Generated matrices that will be stored later in the matrix store will be saved from garbage collection as all other snaphot matrices.
The changelog is maintained by hand in documentation, it's better to use it everywhere for consistency sake. Also, generated changelog did not seem to match the released version (see changelog in v2.17.5 zip which only contains changes up to v2.17.4). --------- Signed-off-by: Sylvain Leclerc <sylvain.leclerc@rte-france.com>
Signed-off-by: Sylvain Leclerc <sylvain.leclerc@rte-france.com>
Signed-off-by: Sylvain Leclerc <sylvain.leclerc@rte-france.com>
Signed-off-by: Sylvain Leclerc <sylvain.leclerc@rte-france.com>
Signed-off-by: Sylvain Leclerc <sylvain.leclerc@rte-france.com>
Signed-off-by: Sylvain Leclerc <sylvain.leclerc@rte-france.com>
Signed-off-by: Sylvain Leclerc <sylvain.leclerc@rte-france.com>
Signed-off-by: Sylvain Leclerc <sylvain.leclerc@rte-france.com>
Signed-off-by: Sylvain Leclerc <sylvain.leclerc@rte-france.com>
sylvlecl
previously approved these changes
Aug 29, 2024
Signed-off-by: Sylvain Leclerc <sylvain.leclerc@rte-france.com>
sylvlecl
approved these changes
Aug 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
linked to https://gopro-tickets.rte-france.com/browse/ANT-1966