Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: move all build and project configuration to pyproject.toml #2122

Merged
merged 3 commits into from
Aug 20, 2024
Merged

build: move all build and project configuration to pyproject.toml #2122

merged 3 commits into from
Aug 20, 2024

Conversation

sylvlecl
Copy link
Member

Configuration were arbitrarily dispatched between setup.py, setup.cfg, and the newer pyproject.toml.

@sylvlecl
Moves all build and project configuration to pyproject.toml
fb26b79 
Configuration were arbitrarily dispatched between setup.py,
setup.cfg, and the newer pyproject.toml.

Signed-off-by: Sylvain Leclerc <sylvain.leclerc@rte-france.com>
MartinBelthle
MartinBelthle reviewed Aug 20, 2024
View reviewed changes
Copy link
Contributor

@MartinBelthle MartinBelthle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only change i think you should do is inside file update_version.py as it still uses setup.py line 120.

@sylvlecl
Fix update_version script
052019d 
Signed-off-by: Sylvain Leclerc <sylvain.leclerc@rte-france.com>
@sylvlecl sylvlecl marked this pull request as ready for review August 20, 2024 11:28
@sylvlecl sylvlecl changed the title Moves all build and project configuration to pyproject.toml build: Moves all build and project configuration to pyproject.toml Aug 20, 2024
@sylvlecl sylvlecl changed the title build: Moves all build and project configuration to pyproject.toml build: move all build and project configuration to pyproject.toml Aug 20, 2024
@sylvlecl sylvlecl merged commit 8c0b09e into dev Aug 20, 2024
9 of 10 checks passed
@sylvlecl sylvlecl deleted the feature/only-pyproject-toml branch August 20, 2024 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MartinBelthle MartinBelthle MartinBelthle approved these changes

Assignees
No one assigned
Labels
size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sylvlecl @MartinBelthle