Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reserve model : trial for a fix on reserve model #2470

Open
wants to merge 2 commits into
base: feature/reserve_model_lot2_scalian
Choose a base branch
from

Conversation

guilpier-code
Copy link
Contributor

@guilpier-code guilpier-code commented Oct 23, 2024

This work is a trial to fix a crash occurring when running Antares Simulator on a study named BP23_A-Reference_2031.
This crash was reported by a student supervised by @thibaulttoujouse.

The current work does not fix the crash, but is worth to be integrated in the reserve model work.

What was done :

  • commit 1 : fix on a compilation issue on Windows + debug
  • commit 2 : cherry pick of a crash fix commit from another branch to see if it fixes the crash on study BP23_A-Reference_2031.

guilpier-code and others added 2 commits October 23, 2024 11:26
Before this commit, compiler cl.exe crashes (I did not know it was possible) on compiling file cluster_list.cpp
@guilpier-code
Copy link
Contributor Author

guilpier-code commented Oct 23, 2024

The CI fails on Windows and Linux for now.
We should see why (if needed) :

  • is it due to changes introduced by this commit ?
  • is it due to base branch content ?

@bencamus bencamus force-pushed the feature/reserve_model_lot2_scalian branch from 92d7ad1 to 0c9eca8 Compare November 6, 2024 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant