Skip to content
This repository has been archived by the owner on Jan 19, 2024. It is now read-only.

Fix clang-tidy warnings #11

Merged
merged 1 commit into from
Mar 13, 2023
Merged

Fix clang-tidy warnings #11

merged 1 commit into from
Mar 13, 2023

Conversation

mikelik
Copy link
Contributor

@mikelik mikelik commented Mar 9, 2023

No description provided.

@mikelik mikelik self-assigned this Mar 9, 2023
ScottBailey
ScottBailey approved these changes Mar 10, 2023
View reviewed changes
Copy link
Contributor

@ScottBailey ScottBailey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

dimas1185
dimas1185 approved these changes Mar 10, 2023
View reviewed changes
Copy link
Contributor

@dimas1185 dimas1185 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. the only optional thing I suggest to do is to remove unused variables from interface at all if that is reasonable.

@ScottBailey ScottBailey merged commit 16512c3 into larryk85/proj-changes Mar 13, 2023
@ScottBailey ScottBailey deleted the mikelik/clang-tidy branch March 13, 2023 14:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dimas1185 dimas1185 dimas1185 approved these changes

@ScottBailey ScottBailey ScottBailey approved these changes

@larryk85 larryk85 Awaiting requested review from larryk85

Assignees

@mikelik mikelik

Labels
None yet
Projects
Team Backlog
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mikelik @ScottBailey @dimas1185