-
Notifications
You must be signed in to change notification settings - Fork 0
Conversation
docs/man/make_man.sh
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a useful script, but maybe we should build the manpage from cmake?
Here's a cmake module file that might help or we can work through it together. I imagine this is a custom target and an install command.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a useful script, but maybe we should build the manpage from cmake?
Here's a cmake module file that might help or we can work through it together. I imagine this is a custom target and an install command.
I don't know. I left this script just to save a command for conversion. Anyone can edit the markdown file and just run the script instead of reading pandoc documentation. Of course you may add building of the man page anywhere you wish. But when you do editing of the page you may convert it manually for many times in order to see how it looks on terminal. So IMHO building man pages during building of the project or the installation package is another task which doesn't take a content of the page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should avoid adding build artifacts to our repo. Please remove. But do address Bucky's comments in the source file.
docs/man/antler-proj.1.md
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Per Bucky's comments above, please convert aproj
to antler-proj
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove the build artifact, change aproj
to antler-proj
, and update the CMake file to build the man page.
If you mean that the |
My concern is two fold:
Additionally, I believe the risk of the artifact losing sync to source is more problematic than needing to install pandoc to view a potentially out of date manpage... And the user can always open the .md source file anyway. |
IMHO building of code and writing of documentation are different tasks. So I propose to add the document and then talk about how to integrate it to the building process. IMHO it should include not only installation of pandoc and conversion but also building of the install packages. Maybe it make sense to think about conversion to help formats of other supported systems because Windows doesn't support man. Again it is a separated big issue but it is not a cause don't add a man page right now. Anyway if you believe it should be in CMake file add it as you wish, you know better how it should be I'm not against it. I just want to leave the man file in order don't force people install pandoc just to get the man page. Could you tell a realistic scenario how somebody may change a man file directly and it will be approved and make a big problem? Anyway if you add the conversion step into the building process it will recreate the man file. |
Created issue #25 to address missing build and install targets. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Issue #25 addresses my outstanding comments.
man pages - minor corrections
A page for the man utility has been added. It includes a markdown file, a script for generation of a man page by pandoc utility and a generated man page.