Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

blake2_f() in crypto_ext.hpp is not inline leading to duplicate symbol errors #110

Closed
spoonincode opened this issue Mar 6, 2023 · 0 comments · Fixed by #113
Closed

blake2_f() in crypto_ext.hpp is not inline leading to duplicate symbol errors #110

spoonincode opened this issue Mar 6, 2023 · 0 comments · Fixed by #113
Labels
actionable bug Something isn't working

Comments

@spoonincode
Copy link
Member

blake2_f() in crypto_ext.hpp is not inline nor static, so if multiple .cpp files include this header file there will be duplicate symbol errors.
@spoonincode spoonincode added the bug Something isn't working label Mar 6, 2023
@heifner heifner added actionable and removed triage labels Mar 7, 2023
@guilledk guilledk mentioned this issue Mar 7, 2023
Merged
spoonincode added a commit that referenced this issue Mar 8, 2023
@spoonincode
Merge pull request #113 from guilledk/fix_crypto_ext_inline
7c2c7e8 
Resolve #110: Add missing inline declaration on blake2_f intrinsics helper
@github-project-automation github-project-automation bot moved this from Todo to Done in Team Backlog Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
actionable bug Something isn't working
Projects
Team Backlog
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Resolve #110: Add missing inline declaration on blake2_f intrinsics helper guilledk/cdt
3 participants
@heifner @spoonincode @enf-ci-bot