[3.0] Move new crypto primitives out of crypto.h and crypto.hpp, and add missing ones to the new hpp file #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
currently only sha3 is exposed in crypto.hpp; add k1_recover, alt_bn128_add, alt_bn128_mul, alt_bn128_pair, and mod_exp to the header file. Those new primitives require crypto protocol feature to be activated. Seperate them from regular crypto.h and crypto.hpp so they are included only when needed.
Closed
Closed
larryk85
approved these changes
Aug 30, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #17
Currently only
sha3is exposed incrypto.hpp. Addk1_recover,alt_bn128_add,alt_bn128_mul,alt_bn128_pair, andmod_expto the header file.The new primitives require crypto protocol feature to be activated. Move them out from regular
crypto.handcrypto.hppand place incrypto_ext.handcrypto_ext.hpp, so they are included only when needed.Change Description
API Changes
Documentation Additions