Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[4.0 -> main] add explicit overloads #227

Merged
merged 3 commits into from
Sep 19, 2023
Merged

[4.0 -> main] add explicit overloads #227

merged 3 commits into from
Sep 19, 2023

Conversation

spoonincode
Copy link
Member

This merges up #191 to main.. which it appears never was months ago.

ericpassmore
ericpassmore approved these changes Sep 19, 2023
View reviewed changes
Copy link
Contributor

@ericpassmore ericpassmore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, code previously merged in 4.0 branch. moving it to main.

@spoonincode spoonincode merged commit 6683402 into main Sep 19, 2023
6 checks passed
@spoonincode spoonincode deleted the basic_string_fix_to_main branch September 19, 2023 22:57
@ericpassmore
Copy link
Contributor

Note:start
group: STABILITY
category: BUG
summary: Add explicit stream operator overloads.
Note:end

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dimas1185 dimas1185 dimas1185 approved these changes

@ericpassmore ericpassmore ericpassmore approved these changes

@heifner heifner heifner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@spoonincode @ericpassmore @heifner @dimas1185