-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BLS: add benchmarking for Affine form host functions #1904
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Strange, it looks like providing the parameters in Montgomery form doesn't make a significant difference. |
linh2931
changed the title
BLS: add benchmarking for Montgomery form host functions
BLS: add benchmarking for Affine form host functions
Nov 15, 2023
heifner
approved these changes
Nov 15, 2023
greg7mdp
reviewed
Nov 15, 2023
greg7mdp
reviewed
Nov 15, 2023
All _mont function removed now. Benchmarks for them should be removed. |
Thanks for the reminder. Removed. |
greg7mdp
approved these changes
Nov 16, 2023
yarkinwho
approved these changes
Nov 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Benchmarking for Affine form host functions.
Did a comparison between Jacobian form and Affine form.
Jacobian form
Affine form