Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.2->main] compute_transaction: add --dry-run, deprecate --read-only, and sign a transaction only when explicitly requested #487

Merged
merged 4 commits into from
Nov 17, 2022

Conversation

linh2931
Copy link
Member

This is a merge of #483 from release/3.2 to main.

Resolve #482

Currently cleos push transaction --read-only is used to send transactions to compute_transaction endpoint. Those are not true read-only transactions. To avoid confusions when true read-only transactions are introduced, we plan to use --read for true read-only transaction endpoint, deprecate --read-only, and use --dry-run to send transactions to compute_transaction endpoint.

In addition, to prevent dry-run transactions from accidentally being included in a block, cleos will change to not sign dry-run transactions by default, unless explicitly requested with --sign-with option. Behavior of transactions by --read-only is not changed.

linh2931 and others added 4 commits November 17, 2022 10:55
… transaction only when --sign-with is provided
[3.2] compute_transaction: add --dry-run, deprecate --read-only, and sign a transaction only when explicitly requested
@linh2931 linh2931 requested a review from heifner November 17, 2022 19:40
@linh2931 linh2931 merged commit 04b4638 into main Nov 17, 2022
@linh2931 linh2931 deleted the compute_transaction_fix_main branch November 17, 2022 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants