Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.0-beta1 -> main] P2P: Fix switch from lib catchup to head catchup #149

Merged
merged 6 commits into from
May 16, 2024

Conversation

heifner
Copy link
Member

@heifner heifner commented May 16, 2024

When syncing do not mark a block as applied until it is actually applied to the chain state.
Reverting this commit: AntelopeIO/leap@fdeb7fc with the comment "GH-2125 If we have the block in our dispatcher list then it is applied". The comment is wrong. A block that is in the dispatcher list is not necessarily applied. We can not assume that a block is applied just because we have added it to our received block list. We distinguish from received blocks and applied blocks in sync_manager to know the current state of syncing. The indication that the block is already applied confused sync_manager so that it doesn't request the correct blocks.

Introduced in AntelopeIO/leap#2290

Merges release/1.0-beta1 into main including #146 & #147

Resolves #141

@heifner heifner requested review from linh2931 and spoonincode May 16, 2024 14:47
@heifner heifner added the OCI Work exclusive to OCI team label May 16, 2024
@heifner heifner merged commit 94231e5 into main May 16, 2024
36 checks passed
@heifner heifner deleted the merge-beta1 branch May 16, 2024 19:13
@ericpassmore
Copy link
Contributor

Note:start
group: IF
category: BUG
summary: P2P: Fix switch from lib catchup to head catchup. Fixes bug which incorrectly assumed blocks in dispatcher list were applied.
Note:end

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCI Work exclusive to OCI team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Jungle Slownet] Problems Syncing From Peers
4 participants