[1.0.1] Verify block signature first when creating block_state

[heifner]

When creating a block_state, verify the block signature before ingesting anything from the block.

[greg7mdp]

Shouldn't we verify the block signature even before we start validating the block header extensions? First thing in create_block_state_i?

[heifner]

Shouldn't we verify the block signature even before we start validating the block header extensions? First thing in create_block_state_i?

I think in general we should consider verification to be allowed in parallel. The point of this PR is that we complete block signature verification before integrating the block. The order of any verification before integration shouldn't matter.

[greg7mdp]

Shouldn't we verify the block signature even before we start validating the block header extensions? First thing in create_block_state_i?

I think in general we should consider verification to be allowed in parallel. The point of this PR is that we complete block signature verification before integrating the block. The order of any verification before integration shouldn't matter.

In general I agree, except that our extension/qc verification code itself could have bugs causing nodeos to abort. It seems safer to be to validate signatures first (old reliable code), to ensure that the block header extensions that we verify next were not tampered with.

[ericpassmore]

Note:start
group: STABILITY
category: INTERNALS
summary: When creating a block_state, verify the block signature before ingesting anything from the block.
Note:end

[ericpassmore]

Note:start
category: Other
component: Internal
summary: When creating a block_state, verify the block signature before ingesting anything from the block.
Note:end