Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1.0.1] Implement the two tests required to validate issue #694 #711

Merged
merged 13 commits into from
Sep 6, 2024
Merged

[1.0.1] Implement the two tests required to validate issue #694 #711

merged 13 commits into from
Sep 6, 2024

Conversation

greg7mdp
Copy link
Contributor

@greg7mdp greg7mdp commented Sep 5, 2024 •
edited
Loading

Partially resolves #694

Implements the two tests described in issue #694.

Also add a test reproducing issue #709.

These tests are disabled for now, so thart ci/cd test pass.

@heifner heifner changed the title Implement the two tests required to validate issue #694 [1.0.1] Implement the two tests required to validate issue #694 Sep 6, 2024
@greg7mdp greg7mdp merged commit 3dfd243 into release/1.0 Sep 6, 2024
36 checks passed
@greg7mdp greg7mdp deleted the test-snapshot-qc-claim branch September 6, 2024 14:26
@arhag arhag linked an issue Sep 6, 2024 that may be closed by this pull request
Add missing data to block_header_state and change verify_qc_claim to use block_header_state data rather than only looking up a block_state in the fork database #694
Closed
@heifner heifner mentioned this pull request Sep 6, 2024
Merged
@ericpassmore
Copy link
Contributor

Note:start
category: Tests
component: Internal
summary: Add two negative test cases validating that insufficient QC prevents claim from advancing.
Note:end

@ericpassmore ericpassmore added the bug The product is not working as was intended. label Sep 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@linh2931 linh2931 linh2931 approved these changes

@heifner heifner heifner approved these changes

@arhag arhag Awaiting requested review from arhag

Assignees
No one assigned
Labels
bug The product is not working as was intended.
Projects
None yet
Milestone
No milestone
4 participants
@greg7mdp @ericpassmore @heifner @linh2931