Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.0.1] Small improvements left in PR 715 #735

Merged
merged 4 commits into from
Sep 10, 2024
Merged

Conversation

linh2931
Copy link
Member

@linh2931 linh2931 commented Sep 10, 2024

There are several improvements identified in #715 before and after it was merged in:

  • Be explicit about return type to get return value optimization
  • Avoid qc->to_qc_claim() in normal execution path
  • Proper uses of invalid_qc_claim exception type

Completely resolves #693

…on as consider the source of truth to be the QC claim in the block header
@linh2931 linh2931 merged commit eb39cdc into release/1.0 Sep 10, 2024
36 checks passed
@linh2931 linh2931 deleted the followup_pr_715 branch September 10, 2024 18:30
@linh2931 linh2931 added the bug The product is not working as was intended. label Sep 10, 2024
@ericpassmore
Copy link
Contributor

Note:start
category: Other
component: Internal
summary: Part II. Enhance checks for QC on blocks across block types Legacy, Transition, and Proper Savanna.
Note:end

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug The product is not working as was intended.
Projects
None yet
5 participants