Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.0.1] Log received block with qc_claim even if no qc #750

Merged
merged 4 commits into from
Sep 12, 2024

Conversation

heifner
Copy link
Member

@heifner heifner commented Sep 11, 2024

Debug log the received block with qc claim for every proper savanna block even if they do not have a qc. Only log every 1000 blocks if syncing.

Example:

debug 2024-09-11T18:38:19.352 net-2     controller.cpp:3939           verify_basic_proper_ ] received block: #64 2024-09-11T18:38:19.500 eosio 0000004083746bd01620fcf67d3c2e79acf7e6a50285d738aca44060cdbfdb34, qc claim: {"block_num":62,"is_strong_qc":false}, qc not present, previous: 0000003f138e55a7fcffbfffa53e2ff60c430ab28033df903b3714fae7adc30e
debug 2024-09-11T18:38:19.815 net-2     controller.cpp:3939           verify_basic_proper_ ] received block: #65 2024-09-11T18:38:20.000 eosio 000000414c96210ff400fc724135380d4ea7e6017d240f89ee5d9d99bdef509d, qc claim: {"block_num":64,"is_strong_qc":true}, qc present, previous: 0000004083746bd01620fcf67d3c2e79acf7e6a50285d738aca44060cdbfdb34

@heifner heifner added the OCI Work exclusive to OCI team label Sep 11, 2024
@heifner heifner added this to the Spring v1.0.1 milestone Sep 11, 2024
@heifner heifner requested review from arhag and removed request for greg7mdp September 11, 2024 18:45
@heifner heifner merged commit d0a2ffc into release/1.0 Sep 12, 2024
36 checks passed
@heifner heifner deleted the log-received branch September 12, 2024 02:54
@ericpassmore
Copy link
Contributor

Note:start
category: Logging
component: Internal
summary: Log qc_claim on block even if there is no qc. Reduce verbosity by logging every 1000 blocks when syncing.
Note:end

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCI Work exclusive to OCI team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants