Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1.0.1] Add unit tests to verify replay of blocks with bad QC data #759

Merged
merged 14 commits into from
Sep 12, 2024
Merged

[1.0.1] Add unit tests to verify replay of blocks with bad QC data #759

merged 14 commits into from
Sep 12, 2024

Conversation

linh2931
Copy link
Member

@linh2931 linh2931 commented Sep 12, 2024 •
edited
Loading

Adds tests for QC validation during replay of blocks (implemented by #693).

Cases are tested:

  • Invalid QC claim (one that goes backward for example). Replay always fails.
  • Irrelevant QC (claims a block number other than the one claimed in the block header, or mismatching weak/strong claim). Replay always fails.
  • Bad QC (signature validation fails). Replay fails only if --force-all-checks is provided.

Resolves #727

@arhag arhag linked an issue Sep 12, 2024 that may be closed by this pull request
Add unit test to verify replay of blocks with bad QC data #727
Closed
greg7mdp
greg7mdp requested changes Sep 12, 2024
View reviewed changes
unittests/replay_block_invariants_tests.cpp Outdated Show resolved Hide resolved
unittests/replay_block_invariants_tests.cpp Outdated Show resolved Hide resolved
unittests/replay_block_invariants_tests.cpp Outdated Show resolved Hide resolved
unittests/replay_block_invariants_tests.cpp Show resolved Hide resolved
unittests/replay_block_invariants_tests.cpp Outdated Show resolved Hide resolved
unittests/replay_block_invariants_tests.cpp Outdated Show resolved Hide resolved
unittests/replay_block_invariants_tests.cpp Outdated Show resolved Hide resolved
unittests/replay_block_invariants_tests.cpp Outdated Show resolved Hide resolved
unittests/replay_block_invariants_tests.cpp Outdated Show resolved Hide resolved
@linh2931 linh2931 merged commit c114fe5 into release/1.0 Sep 12, 2024
36 checks passed
@linh2931 linh2931 deleted the replay_block_invariants_tests branch September 12, 2024 17:05
@linh2931 linh2931 mentioned this pull request Sep 12, 2024
Merged
@ericpassmore
Copy link
Contributor

Note:start
category: Tests
component: Internal
summary: Add unit tests to verify replay of blocks with bad QC data.
Note:end

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arhag arhag arhag approved these changes

@heifner heifner heifner approved these changes

@greg7mdp greg7mdp greg7mdp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add unit test to verify replay of blocks with bad QC data
5 participants
@linh2931 @ericpassmore @greg7mdp @heifner @arhag