Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Intermediate Update #3

Merged
merged 1 commit into from
Oct 12, 2021
Merged

Conversation

castorw
Copy link
Contributor

@castorw castorw commented Oct 10, 2021

Added intermediate option allowing immediate updates while sliding. By default this should be disabled however it may be very useful for some cases.

My case which led me to do this is control of remote audio mixing console via OSC. The effect when the audio volume is updated in real-time is much better.

@AnthonMS
Copy link
Owner

I actually played around with this when I first created the card, but went away from it because I didn't want to spam my zigbee network with brightness commands on every little change. And hadn't really considered it after I implemented the other device types, but this makes sense to have as an option at least.

And thank you for finally cleaning up my spaghetti code with different functions for each device type, this is much cleaner and I have been wanting to clean up my code for a long time now. Life has just gotten in the way of personal projects lately.

But thank you for the contribution, I will merge it.

@AnthonMS AnthonMS merged commit c01c2c4 into AnthonMS:main Oct 12, 2021
@castorw
Copy link
Contributor Author

castorw commented Oct 12, 2021

You are welcome. I didn't really put much precision into this, but rather went for quick results.
Thanks for merging this 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants