make accelerometer stable #1011
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pepper-jelly
force-pushed
the
master
branch
3 times, most recently
from
e0a303a
to
392df3d
Compare
pktiuk
reviewed
Jul 26, 2024
pepper-jelly
force-pushed
the
master
branch
5 times, most recently
from
72e748b
to
e7c8c13
Compare
I've noticed an issue when pitching forward or backward. I expect only the "up" or "down" directions to be registered, but instead, "left" and/or "right" are also triggered for a brief period.
|
@pktiuk So now it's better and based on the visual feedback, we should use the dead zone for pitch and keep the diagonal range for roll. |
|
@pepper-jelly |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've noticed an issue when pitching forward or backward. I expect only the "up" or "down" directions to be registered, but instead, "left" and/or "right" are also triggered for a brief period.
The SENSOR_CENTERED is 0, so at the end we just return 0 if button not yet triggered while we change direction, otherwise it can crash as it's a non-void function.
Anyway that's what I use for a week and it works for me.