New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing wanings by Infer code analysis #557 #558

Merged

pktiuk merged 1 commit into AntiMicroX:master from Stefan-TU:master

Oct 11, 2022

Contributor

Stefan-TU commented Oct 10, 2022

Closes #557

Proposed changes

Fixed warnings and problems detected by Infer code analysis

Member

pktiuk commented Oct 11, 2022 •

edited

Loading

I think you should check https://github.com/AntiMicroX/antimicrox/wiki/Coding-guidelines#code-style
Code formatting shouldn't be done by hand

Just run clang-format in project directory

Contributor Author

Stefan-TU commented Oct 11, 2022

Yes, sorry for the inconvenience...

pktiuk reviewed

View reviewed changes

src/inputdevice.cpp Outdated Show resolved Hide resolved

pktiuk reviewed

View reviewed changes

src/joybutton.cpp Outdated Show resolved Hide resolved

pktiuk reviewed

View reviewed changes

src/joycontrolstick.cpp Outdated Show resolved Hide resolved

pktiuk reviewed

View reviewed changes

src/joydpad.cpp Outdated Show resolved Hide resolved

pktiuk reviewed

View reviewed changes

src/xml/inputdevicexml.cpp Outdated Show resolved Hide resolved

pktiuk requested changes

View reviewed changes

Member

pktiuk left a comment •

edited

Loading

I found some minor mistakes and places for improvements in your changes :)
Could you also squash all of your changes into one commit with message:

chore: Fix infer code warnings

Stefan-TU commented

View reviewed changes

Contributor Author

Stefan-TU left a comment

Alright, I've changed the code again, gonna commit again, it should be good now. I'm going to smash the commits then.


          chore: Fix infer code warnings

a645f38

Stefan-TU force-pushed the master branch from c8aabc5 to a645f38 Compare

October 11, 2022 10:01

pktiuk merged commit a2dc31c into AntiMicroX:master

Member

pktiuk commented Oct 11, 2022

Thank you for your contribution.
Feel free to check other issues if you want.

Contributor Author

Stefan-TU commented Oct 11, 2022

Thank you for helpful review and tips :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet