This repository has been archived by the owner on Aug 4, 2019. It is now read-only.
A/V Tweaks for 3g connections #171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2500 seems to make worse quality, but the video works more reliable on 3g connections
this will ensure that video will work more reliable on 3g connections
zoff99
commented
Sep 21, 2017
| @@ -7,7 +7,7 @@ | |||
| #import "OCTTox.h" | |||
|
|
|||
| const OCTToxAVAudioBitRate kDefaultAudioBitRate = OCTToxAVAudioBitRate48; | |||
| const OCTToxAVVideoBitRate kDefaultVideoBitRate = 2000; | |||
| const OCTToxAVVideoBitRate kDefaultVideoBitRate = 2500; | |||
There was a problem hiding this comment.
this is OK as default options, since in my opinion most iPhone users will be on 3g network.
but later this should be a user changeable setting:
2500 -> for 3g
500 -> for Wifi (or strong LTE network)
There was a problem hiding this comment.
I guess app should change this parameter itself based on connection type.
dvor
reviewed
Sep 24, 2017
|
|
||
| if ([_captureSession canSetSessionPreset:AVCaptureSessionPreset640x480]) | ||
| { | ||
| _captureSession.sessionPreset = AVCaptureSessionPreset640x480; |
There was a problem hiding this comment.
Hm, GitHub has confusing review interface, my comment was removed. Anyway, let's try 640x480 for now, I'll play with other options later.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.