Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Export error type #90

Merged
merged 4 commits into from
Jul 28, 2024
Merged

Conversation

NickDarvey
Copy link
Contributor

The error type is exposed in the public API (for example, by the return type of load_tokenizer) but right now I can't refer to it without adding a dependency on anyhow myself.

@Anush008 Anush008 changed the title Export error type chore: Export error type Jul 28, 2024
@Anush008
Copy link
Owner

I think we've not exported the common module.

@NickDarvey
Copy link
Contributor Author

@Anush008
Copy link
Owner

Can you run FMT and Clippy?

@NickDarvey
Copy link
Contributor Author

I can't actually compile tbh so I cant run clippy. (There's something pulling in an old version of ring and I'm on Windows ARM64. briansmith/ring#1514)

Copy link
Owner

@Anush008 Anush008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 🙏

@Anush008 Anush008 merged commit c7a4489 into Anush008:main Jul 28, 2024
2 checks passed
github-actions bot pushed a commit that referenced this pull request Jul 28, 2024
## [3.11.1](v3.11.0...v3.11.1) (2024-07-28)

## [3.11.1](v3.11.0...v3.11.1) (2024-07-28)

### 🧹 Chores

* doc comment reranking.rs ([#91](#91)) ([8d58b88](8d58b88))
* Export error type ([#90](#90)) ([c7a4489](c7a4489))
Copy link

🎉 This issue has been resolved in version 3.11.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@NickDarvey NickDarvey deleted the export-error-type branch July 28, 2024 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants