refactor(API): add a user agent #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antazoey
reviewed
Mar 11, 2024
| @@ -117,7 +121,7 @@ def post_transaction( | |||
| b"", | |||
| ) | |||
| ) | |||
| post_dict: Dict = {"signature": signature.hex()} | |||
| post_dict: Dict = {"signature": signature.hex(), "origin": ORIGIN} | |||
There was a problem hiding this comment.
Are you sure this is valid? I don't see it in the OpenAPI doc whereas I do so "origin" in some of the other parts of the doc.
There was a problem hiding this comment.
I got this from safe-eth-py but come to think of it, basically everything else about that package is wrong lol
There was a problem hiding this comment.
Are you sure this is valid? I don't see it in the OpenAPI doc whereas I do so
"origin"in some of the other parts of the doc.
For some reason, only SafeMultisigTransaction has this (optional) field in the swagger
fubuloubu
force-pushed
the
refactor/api/user-agent
branch
from
0abd1f5
to
8a9df63
Compare
antazoey
approved these changes
Jun 5, 2024
fubuloubu
force-pushed
the
refactor/api/user-agent
branch
from
bf2e46f
to
2cc7d69
Compare
fubuloubu
force-pushed
the
refactor/api/user-agent
branch
from
8b2090c
to
c80805e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Noticed in the Safe API transaction service code that a User Agent string is appended to the transaction request when you make a transaction, so I added it
How I did it
Leverage Ape core's user agent string, as well as do a little researching on how it is supposed to be done
How to verify it
Make a transaction on a testnet safe
Checklist
- [ ] New test cases have been added and are passing- [ ] Documentation has been updated