-
-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add dockerfile for automated builds to dockerhub #165
Merged
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
bcb0cf7
feat: added dockerfile
sabotagebeats 178d783
docs: added installing via docker and link to docker repo
sabotagebeats bd272bf
fix: moved dockerfile to Dockerfile
sabotagebeats 303aad2
perf: pinned versions, removed python-is-python3, changed -y to --yes
sabotagebeats 6b84583
feat: entrypoint
sabotagebeats a1266bb
fix: docker copy ape and build from .
sabotagebeats 2b20137
perf: reduce layers, add dockerfile, build from ., add entrypoint
sabotagebeats 0e1dd5e
ref: Merge remote-tracking branch 'upstream/main' into feat/docker
sabotagebeats ce23de6
chore: Merge remote-tracking branch 'upstream/main' into feat/docker
sabotagebeats File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
./tests | ||
./docs | ||
./.github |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
FROM ubuntu:20.04 | ||
RUN apt-get update && apt-get upgrade --yes && apt-get install git python3.8 python3-pip --yes | ||
COPY . . | ||
RUN python3 ./setup.py install | ||
RUN ape plugins add solidity --yes | ||
RUN ape plugins add vyper --yes | ||
RUN ape plugins add infura --yes | ||
RUN ape plugins add etherscan --yes | ||
RUN ape plugins add ens --yes | ||
ENTRYPOINT ["ape"] |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A lot of CLI Dockerfiles I see use ENTRYPOINT so it is like running ape when you run the container, which means if you don't give it commands, it just prints the help and exits... I think you mentioned you looked into this pattern, but just thought I'd say that it is common from what I have seen. How much have we considered this approach?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here is GETH example: https://github.com/islishude/geth-docker/blob/master/Dockerfile
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Notice it builds uses alpine, uses
geth
command as the entrypoint, and it builds from source!There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't used ENTRYPOINT before however I want to make sure that we can do other CLI stuff other than just running
ape console
for exampleape accounts
andape compile
etcThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be what ever command the user types in!
They would run the container with the same args that they run
ape
with. So if they run the container withconsole
as the argument, it would launch a console, etc.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Like this
docker run apeworx/ape console
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes then the problem here then becomes that they can't do other things if they need to with the cli within that image, right?